prepared release of version 1.9.3 #5512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ghostvv
approved these changes
Mar 27, 2020
erohmensing
reviewed
Mar 27, 2020
|
|
||
| Bugfixes | ||
| -------- | ||
| - `#5505 <https://github.com/rasahq/rasa/issues/5505>`_: Set default value for ``weight_sparsity`` in ``ResponseSelector`` to ``0``. |
There was a problem hiding this comment.
Can we make this clearer that it fixes the response selector, so that poeple know that if they're using it they should be on this version?
There was a problem hiding this comment.
@erohmensing Makes sense, this was added in #5505. Can I make it clearer by changing the CHANGELOG.rst directly in this branch itself?
There was a problem hiding this comment.
Added some explanation below.
There was a problem hiding this comment.
@dakshvar22 maybe if it is used in their pipeline? or if they have responses?
just bc the default pipeline has included it since 1.8 regardless of if the user is using it
erohmensing
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)