Fix incorrect attribute for key prefix in RedisTrackerStore #7334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for submitting a pull request 🚀 @dakshvar22 will take a look at it as soon as possible ✨ |
|
@federicotdn Can you please review this as I am not very aware of this part of the code 🙏 |
federicotdn
approved these changes
Nov 25, 2020
|
Could not update branch. Most likely this is due to a merge conflict. Please update the branch manually and fix any issues. |
|
@ducminh-phan could you take a look at this failing build? https://github.com/RasaHQ/rasa/pull/7334/checks?check_run_id=1466365759#step:9:19 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7306
Proposed changes:
self.key_prefixinstead of the erroneousself.prefixinrasa.core.tracker_store.RedisTrackerStore.Status (please check what you already did):
black(please check Readme for instructions)