Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document connecting to an NLU only server #7475

Merged
merged 9 commits into from
Jan 26, 2021
Merged

document connecting to an NLU only server #7475

merged 9 commits into from
Jan 26, 2021

Conversation

indam23
Copy link
Contributor

@indam23 indam23 commented Dec 8, 2020

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@indam23 indam23 requested a review from akelad December 8, 2020 04:02
@akelad
Copy link
Contributor

akelad commented Dec 8, 2020

@melindaloubser1 did you check that it still behaves as expected?

@akelad
Copy link
Contributor

akelad commented Dec 8, 2020

i'm also not sure this belongs in the NLU only section 🤔 you'd usually use that if you're running the dialogue manager and NLU separately

@indam23
Copy link
Contributor Author

indam23 commented Dec 8, 2020

Yes, it does behave as expected. I wasn't really sure where to put it since there isn't an "endpoints" page specifically - should it go under the http api page?

@akelad
Copy link
Contributor

akelad commented Dec 8, 2020

@erohmensing i feel like you probably know better where it should go?

docs/docs/nlu-only.mdx Outdated Show resolved Hide resolved
@akelad akelad requested review from erohmensing and removed request for akelad January 5, 2021 10:07
Comment on lines 70 to 72
The dialogue management server should serve a model that does not include an NLU model.
To obtain a dialogue management only model, train a model with `rasa train core` or use
`rasa train` but exclude all NLU data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put this part at the top where we introduce the "dialogue management only server", or create another short header explaining what that is and how to spin one up

docs/docs/nlu-only.mdx Outdated Show resolved Hide resolved
@indam23 indam23 requested a review from erohmensing January 13, 2021 10:39
@indam23
Copy link
Contributor Author

indam23 commented Jan 13, 2021

Moved it to its own page under API

docs/docs/nlu-only-server.mdx Outdated Show resolved Hide resolved
docs/docs/nlu-only-server.mdx Show resolved Hide resolved
indam23 and others added 2 commits January 15, 2021 16:28
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
@indam23 indam23 changed the base branch from master to 2.2.x January 15, 2021 14:29
@indam23 indam23 requested review from a team and chdorner and removed request for a team January 15, 2021 14:29
@indam23 indam23 changed the base branch from 2.2.x to master January 15, 2021 14:30
@akelad
Copy link
Contributor

akelad commented Jan 22, 2021

@melindaloubser1 can this be merged?

@indam23
Copy link
Contributor Author

indam23 commented Jan 22, 2021

In general yes, but looks like there's a validation error that prevented auto-merging; I'll look into it

Base automatically changed from master to main January 22, 2021 11:15
@rasabot rasabot merged commit e311c1f into main Jan 26, 2021
@rasabot rasabot deleted the nlu_endpoint branch January 26, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document how to connect to external NLU
4 participants