Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for writing NLU intent/example metadata to YAML #7761

Merged
merged 8 commits into from
Jan 25, 2021

Conversation

chdorner
Copy link
Contributor

@chdorner chdorner commented Jan 20, 2021

Proposed changes:
This adds support to the RasaYAMLWriter for writing intent and example metadata back into YAML files.
The parsing functionality has been added in #5989.

Fixes #7731

Status (please check what you already did):

  • added some tests for the functionality
  • [ ] updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@chdorner chdorner self-assigned this Jan 20, 2021
@chdorner chdorner force-pushed the 7731/dump-nlu-metadata branch 2 times, most recently from 4b631dc to 5b2176d Compare January 20, 2021 15:27
@chdorner chdorner marked this pull request as ready for review January 20, 2021 16:17
@chdorner chdorner requested review from a team, wochinge and degiz and removed request for a team January 20, 2021 16:17
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, what an issue as first issue 🙈 Do you know by chance if there is any issue for implementing metadata for stories?

Your code looks great - most of my comments are about some naming stuff 😄

@@ -19,13 +19,15 @@
)


MULTILINE_INTENT_EXAMPLES = f"""
version: "{LATEST_TRAINING_DATA_FORMAT_VERSION}"
MULTILINE_INTENT_EXAMPLES = f"""version: "{LATEST_TRAINING_DATA_FORMAT_VERSION}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you! This will avoid cluttering the CI with useless logs 🙌🏻

tests/shared/nlu/training_data/formats/test_rasa_yaml.py Outdated Show resolved Hide resolved
rasa/shared/nlu/training_data/formats/rasa_yaml.py Outdated Show resolved Hide resolved
rasa/shared/nlu/training_data/formats/rasa_yaml.py Outdated Show resolved Hide resolved
rasa/shared/nlu/training_data/formats/rasa_yaml.py Outdated Show resolved Hide resolved
rasa/shared/nlu/training_data/formats/rasa_yaml.py Outdated Show resolved Hide resolved
rasa/shared/nlu/training_data/formats/rasa_yaml.py Outdated Show resolved Hide resolved
rasa/shared/nlu/training_data/formats/rasa_yaml.py Outdated Show resolved Hide resolved
@chdorner chdorner force-pushed the 7731/dump-nlu-metadata branch from acaa887 to 251c2df Compare January 22, 2021 10:24
@chdorner chdorner requested a review from wochinge January 22, 2021 10:26
@chdorner chdorner force-pushed the 7731/dump-nlu-metadata branch from 251c2df to 65cc34b Compare January 22, 2021 12:22
@chdorner chdorner force-pushed the 7731/dump-nlu-metadata branch from 65cc34b to ca52ad8 Compare January 25, 2021 11:06
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats to your first PR! Very clean solution 💯

@rasabot rasabot merged commit fb668ca into 2.2.x Jan 25, 2021
@rasabot rasabot deleted the 7731/dump-nlu-metadata branch January 25, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants