-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for writing NLU intent/example metadata to YAML #7761
Conversation
4b631dc
to
5b2176d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, what an issue as first issue 🙈 Do you know by chance if there is any issue for implementing metadata for stories?
Your code looks great - most of my comments are about some naming stuff 😄
@@ -19,13 +19,15 @@ | |||
) | |||
|
|||
|
|||
MULTILINE_INTENT_EXAMPLES = f""" | |||
version: "{LATEST_TRAINING_DATA_FORMAT_VERSION}" | |||
MULTILINE_INTENT_EXAMPLES = f"""version: "{LATEST_TRAINING_DATA_FORMAT_VERSION}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thank you! This will avoid cluttering the CI with useless logs 🙌🏻
acaa887
to
251c2df
Compare
251c2df
to
65cc34b
Compare
This preserves the YAML structure of the input as much as possible.
65cc34b
to
ca52ad8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats to your first PR! Very clean solution 💯
Proposed changes:
This adds support to the
RasaYAMLWriter
for writing intent and example metadata back into YAML files.The parsing functionality has been added in #5989.
Fixes #7731
Status (please check what you already did):
[ ] updated the documentationblack
(please check Readme for instructions)