-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Locking Mechanism to Reminders Handler #7895
Conversation
@wochinge I added lock_store as an input parameter to MessageProcessor so that handle_reminder could lock the conversation, but not entirely sure if this is the best way to do it. Wdyt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for providing the fix! Will you also implement that for 2.x?
@wochinge Yes, definitely. I'll create a PR for 2.X as well once this fix is good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you also test this manually? If so, how?
@wochinge Yes, I tested manually using the ReminderBot with redis-server running locally and the SocketIO channel. Redis logs showed the lock correctly being acquired and deleted when the reminder was handled. |
Nice job 💯 |
Proposed changes:
Status (please check what you already did):
black
(please check Readme for instructions)