You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ztfm.c includes a test whose intention is to verify that a transform runs to completion in the absence of ambiguous references to objects in the transform. The test setup isn't sufficient to create the desired test environment and at least one compiler under specific conditions appears to store/"spill" ambiguous references onto the stack, invalidating the test. The transform fails to complete, creating a false positive test result. This was observed here (gcc 11.3.0 )
This issue could be fixed by redesigning the testing of transforms (see #242 )
The text was updated successfully, but these errors were encountered:
Currently, the test declares the stack as an ambiguous root, to ensure that the C code is GC-safe. However, there are other ways of achieving this. (The amcss test does not declare the stack, for example.) In this case, it's not the duty of this test to check the interaction of the incremental GC with the C code. I suggest not declaring the stack, and arranging that all graph-manipulating operations are done while the arena is parked. (Transforms require the arena to be parked anyway.) The test can release the arena to run manual GCs after manipulating the graph, in order to check that Transforms work when GCs have been run.
We could check that this works well by restructuring the existing test code before redesigning it in response to #242 .
ztfm.c includes a test whose intention is to verify that a transform runs to completion in the absence of ambiguous references to objects in the transform. The test setup isn't sufficient to create the desired test environment and at least one compiler under specific conditions appears to store/"spill" ambiguous references onto the stack, invalidating the test. The transform fails to complete, creating a false positive test result. This was observed here (gcc 11.3.0 )
This issue could be fixed by redesigning the testing of transforms (see #242 )
The text was updated successfully, but these errors were encountered: