Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedback on mvc example #10

Open
Raynos opened this issue Nov 28, 2013 · 3 comments
Open

feedback on mvc example #10

Raynos opened this issue Nov 28, 2013 · 3 comments

Comments

@Raynos
Copy link
Owner

Raynos commented Nov 28, 2013

I did a large mvc example

I want it to demonstrate a way of structuring applications that's not stupid but also not too opinionated / bullshit.

It would be good to get some eyes on it.

@Matt-Esch you had some opinions about structuring applications as standalone feature folders. I tried to structure it like that, would love to hear about the good & bad.

@thlorenz you had some opinions about structuring larger apps as modules. I tried to structure it like that, would to love to hear about the good & bad

@Matt-Esch
Copy link
Collaborator

So in general the structure is fine. It would be nice to get this example to the point of production readiness as I think it is lacking some things at the moment.

  • An example "domain" i.e. a fat business logic require, for completeness
  • Integrate domains and clustering of the routes, since everyone should want to do this
  • Add a reasonable error handling and logging mechanism, again because everyone should want to do this
  • Not mutating the config, but creating a deps objects with config as a property plus the additions
  • Demonstrate environment based switching, helpful for people with different dev/production configs (for things like oauth) or persistence strategies (useful to Azure devs)

@Raynos
Copy link
Owner Author

Raynos commented Dec 7, 2013

@Matt-Esch

@Raynos
Copy link
Owner Author

Raynos commented Dec 7, 2013

@Matt-Esch do you want to make PR demonstrating logging & error handling ? (maybe consider using bunyan).

Would you also like to PR a new clustering example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants