-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blpAuthenticate identity support missing from functions #284
Comments
Thanks for opening the ticket. We generally recommend doing this first that is before a PR gets submitted -- as you already did in #283 -- as it tends to be easier to discuss first. I never used or needed auth object so I will have to leave the details to @johnlaing and others. |
The pull request is for a related, but different set of issues. The pull is for a default identity object. This issue is for functions that don't have support for identity at all. I can certainly open an issue for the pull request if you like. |
Ok, I let you discuss this with @johnlaing. I don't have to say about auth and idendity. |
Yes, I do think identity should be added here. Assuming consistency in the underlying API, these are straightforward to implement. |
I don't think this has been addressed, and should be re-opened. These functions (in first comment) don't have any support for identity in the function definitions. I don't see it being hard to add, and it's on my list (somewhere). |
Sorry, you are correct - this is distinct from the other. |
Is it possible to get this fixed? I use e.g. getBars but can't use it with server API as the authentication token doesn't get passed through. |
Can you work on a PR that you can test locally? |
I need to download a compiled package via a URL in my environment. Happy to test a compiled version, test or otherwise. |
You can probably approximate that using win-builder at https://win-builder.r-project.org/ (via ftp or the upload page listed) as it can access GitHub for the compile BLP API library we use. That would allow you to drive a viability test. |
Ok I see - yes happy to try that out |
When would a fix be available please? |
I would think that depends on you -- we were giving you a chance to try that as you are the one who can test it. |
Hello, May I know if you are planning on resolving this issue (open in 2019) or if the support of the Rblpapi doesn't exist anymore ? @eddelbuettel @randomee |
@joltcrow PRs remain welcome. The package is at CRAN, free of issues there and maintained. |
Several functions don't support passing an identity auth object. Which means they don't work over SAPI or Bpipe . The fuctions missing support are:
I don't have need for these. (Or, rather can use a terminal connection when I do.) I'll try to add the support when I have time. But don't hold your breath. :-)
The text was updated successfully, but these errors were encountered: