Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A mysterious tab \t in the vignette datatable-reference-semantics.Rmd #5735

Closed
yihui opened this issue Nov 9, 2023 · 4 comments
Closed

A mysterious tab \t in the vignette datatable-reference-semantics.Rmd #5735

yihui opened this issue Nov 9, 2023 · 4 comments

Comments

@yihui
Copy link

yihui commented Nov 9, 2023

Re-posted from https://github.com/Rdatatable/data.table/pull/5182/files#r1380402289

I discovered a really weird thing on line 95 in vignettes/datatable-reference-semantics.Rmd:

@MichaelChirico has fixed the code fence two years ago, but if you download the source package from CRAN: https://cran.r-project.org/src/contrib/data.table_1.14.8.tar.gz you will find that the first two spaces on this line are actually a tab \t. I don't know what's going on. It will be great if the closing fence could match the opening fence strictly, as the mismatch will be disallowed in knitr in the near future: yihui/knitr#2306 Thanks!

@MichaelChirico
Copy link
Member

@yihui I can't say for sure #5182 has made it to a CRAN release yet, can you check if the problem is fixed on current master?

that would be from the R CMD build output tar.gz at current HEAD.

If so, we should include this in the next patch release CC @jangorecki

@yihui
Copy link
Author

yihui commented Nov 9, 2023

Yes, I have checked the master branch, and the leading white spaces are truly four spaces, not a tab.

@MichaelChirico
Copy link
Member

OK, I checked on the patch release branch (https://github.com/Rdatatable/data.table/tree/hotfix1.14.10) -- the \t was still there, so I think the root issue is that #5182 was never released to CRAN.

I applied the fix to the next patch release, which should hit CRAN "soon".

@yihui
Copy link
Author

yihui commented Nov 9, 2023

Perfect. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants