-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(YouTube): Autoplay fails when Sponsorblock skips to end of video #2817
Comments
There already is a fix that adjusts the segment end time if it runs over the actual video length. Try repatching and exclude If that does not fix it, then repatch with only |
Problem persists with minimal patch. |
Post a public playlist that reproduces the problem. |
Requested Playlist Issue applies to any and all videos and playlists fitting the criteria explained above, so I assumed reproduction would be trivial. |
I cannot reproduce on my end. When using either autoskip or manual skip, the playlist continues to the next video after the skip. Try using a different YouTube account and/or try incognito mode. Maybe it's an unrelated a/b test that is interfering. If anyone else can reproduce this and is savy with building locally, they can try adjusting the end segment skip logic here, and try increasing the 250 to a larger value and maybe that will fix it. |
Problem persists with alternate account and incognito mode. Also: The bug only appeared after the watch history changes, and me updating/replacing my Rev client, autoplay worked as intended prior to that. I'll give this a couple days and pray that someone else can reproduce, I really don't wanna have to set myself up for app dev over this. Thank you! |
With no repro, I decided I don't care enough to try to patch this myself, the effort would be completely disproportionate since I'm not set up for it and I don't know anything about the Rev and YT codebases or the languages used. Thank you for your help. |
Bug description
When a Sponsorblock segment stretches to the end of a video, and that segment is skipped, Autoplay does not correctly trigger to play the next video.
Applies whether the segment is manually or automatically skipped.
Applies to both playlists and non-playlist autoplay.
Steps to reproduce:
(For testing, large commercial YouTube channels are a good place to look, for abundant and aggressive segmenting, as well as consistent skippable filler)
Error logs
No response
Solution
Bodge suggestion:
Add a special case when a segment's end time is identical with the end time of a video, and reduce the segment's end time by a fraction of a second before skipping. This should let the final frame(s) play normally, meaning autoplay should trigger normally.
A proper solution would likely involve manually triggering the next video on that special case, I have no knowledge about this.
Additional context
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: