Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: (YouTube) Shorts and Post showing infinity loading in subscription page #2892

Closed
3 tasks done
dushmanta05 opened this issue Mar 17, 2024 · 6 comments
Closed
3 tasks done
Labels
Bug report Something isn't working

Comments

@dushmanta05
Copy link

dushmanta05 commented Mar 17, 2024

Bug description

I've hidden the shorts and post component in Revanced setting but in subscription page the shorts and post option is visible and clicking on them shows infinity loading screen.

I've attached a video reference below

Revanced.YT.Bug.mp4

Error logs

No response

Solution

No response

Additional context

No response

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@dushmanta05 dushmanta05 added the Bug report Something isn't working label Mar 17, 2024
@LisoUseInAIKyrios
Copy link
Contributor

The Shorts selector button shows infinite loading because you have Hide Shorts in feed turned on, and every item is hidden, so it keeps trying to load the next page of items (which then hides everything, and it loads then next page, etc).

The post selector is showing an infinite loop because you have Hide community posts turned on in the Feed setting.

If you want those items hidden, then do not use those subscription buttons.

But if it is not difficult, those buttons should be hidden by the patches just to prevent this situation.

@oSumAtrIX
Copy link
Member

This is not a bug currently as the patches hide the content. A feature to selectively hide them in the home or search feed could be added

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Mar 17, 2024
@LisoUseInAIKyrios
Copy link
Contributor

For anyone who wants to try patching out the selector buttons, they are regular Android layout items (not Litho).

So it should be do-able to hide them, just gotta spend the time to figure out an appropriate patch.

@dushmanta05
Copy link
Author

dushmanta05 commented Mar 17, 2024

Thank you for your responses. I thought the bug section would be appropriate for this issue, so I opened it under this. I would love to do this patch, but I've got no experience in Android development. But I'll give it a try.

@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Mar 17, 2024

On YT 19.09.37 the UI class for the selector buttons is hng.

Hiding the buttons is not difficult, and the work is figuring out how to distinguish what each button is (without relying on simply checking for the language specific strings it shows).

@dushmanta05
Copy link
Author

Cool! Thanks for the detailed explanation, I guess figuring out distinguish button is the tricky part here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants