Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube): Shorts show in home feed when opening the app #3005

Closed
3 tasks done
0frd opened this issue Apr 8, 2024 · 8 comments · Fixed by #3007 or #2982
Closed
3 tasks done

bug(YouTube): Shorts show in home feed when opening the app #3005

0frd opened this issue Apr 8, 2024 · 8 comments · Fixed by #3007 or #2982
Labels
Bug report Something isn't working

Comments

@0frd
Copy link

0frd commented Apr 8, 2024

Bug description

Shorts showup when open the app then refresh the homefeed it will disappear, close the app and open again and it will showup again and repeat

Error logs

No response

Solution

Refresh the homefeed will make it disappear, but if you close the app it will showup again when you open the app
Screenshot_2024-04-09-06-43-10-955_com google android youtube-edit~2

Additional context

No response

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@0frd 0frd added the Bug report Something isn't working label Apr 8, 2024
@oSumAtrIX
Copy link
Member

Hide shorts in feed using the "Hide Shorts components" patch

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Apr 8, 2024
@0frd
Copy link
Author

0frd commented Apr 8, 2024

Hide shorts in feed using the "Hide Shorts components" patch

I absolutely using it

@oSumAtrIX
Copy link
Member

Show a recording of how it's enabled and shorts still show up.

@0frd
Copy link
Author

0frd commented Apr 9, 2024

Show a recording of how it's enabled and shorts still show up.

0409-01_1712621920622.mp4

@oSumAtrIX oSumAtrIX reopened this Apr 9, 2024
@oSumAtrIX
Copy link
Member

oSumAtrIX commented Apr 9, 2024

Could be caused by https://github.com/ReVanced/revanced-integrations/blob/530ba18364af63ce7d3f9421b9ac0c1462250c82/app/src/main/java/app/revanced/integrations/youtube/patches/components/ShortsFilter.java#L226.

@LisoUseInAIKyrios It could be that NavigationBar.NavigationButton.HOME.isSelected() doesn't work reliably here because of the way the user exits the library tab.

@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Apr 9, 2024

Edit: It is the back button. The navigation tab is a few milliseconds slow to update, and the litho filter (running on a background thread) is called before the nav tab UI changes. The issue shows up for all tabs if the back button changes the active tab.

@LisoUseInAIKyrios
Copy link
Contributor

@0frd the back button issue is fixed. Shorts displaying on startup should also be fixed but I could not reproduce the issue so I cannot verify.

You can try verifying by patching with dev release using a computer and CLI tools, or wait until dev is merged to main and patch using Manager.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug(Youtube): shorts always showup at homefeed when open the app bug(YouTube): Shorts show in home feed when opening the app Apr 14, 2024
@0frd
Copy link
Author

0frd commented Apr 19, 2024

@0frd the back button issue is fixed. Shorts displaying on startup should also be fixed but I could not reproduce the issue so I cannot verify.

You can try verifying by patching with dev release using a computer and CLI tools, or wait until dev is merged to main and patch using Manager.

Yes, confirmed its working, also problem on shorts buttons fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
3 participants