bug: (youtube/spoof-storyboard) seekbar thumbnails may be empty or of a previous video #31
Comments
|
When this happens, does it show a timeout toast? If so then this is not the same as 3370. The connection timeout could be increased, since the app can wait any amount of time for the fetch to completely (the main thread is not blocked). |
|
Nope it doesn't |
|
It's possible the first storyboard call is somehow returning an 'ok' playability status, but sometimes it is missing the storyboard data. If this is true, then this issue did not show up in old releases because the client would always try the android tv backup API and that always works for these situations. This might might be fixed by changing the 'empty storyboard ' logic to only be used if the android tv response is also missing the storyboard. Will make a PR with this change soon. If anyone wants to, they can try patching with CLI and the prior release, and verify they don't have this issue: https://github.com/ReVanced/revanced-patches/releases/tag/v2.201.0 |
|
I'm 99% certain this issue also occured on v2.201.0 |
You can try using it and be 100% certain if the issue does exist. |
Yes, just tested 2.201.0 on another device. |
n1cKz1
changed the title
|
I also just got a bug where the thumbnails were that of a previous video. Tried to reproduce it to no avail, happened kinda randomly. But perhaps it might be the same issue with empty thumbnails only instead this time it had already loaded those of the previous video and kept them instead after it couldn't properly fetch the new ones |
|
@n1cKz1 use CLI tools and install this release. Anyone else who experiences this issue can also try: https://github.com/ReVanced/revanced-integrations/releases/tag/v0.122.0 This prior release has a different issue where the video can initially be frozen while the audio plays, but ignore that and verify if the wrong/missing thumbnails is fixed. If this fixes it, then the issue is the renderer is being called for before the player response has finished fetching. That causes it to use no thumbnails (on first video load after cold app start), or it uses the prior video thumbnails. |
|
That seems to be it yes. Messed around for a few mins and I can't seem to reproduce the bug on that version. |
|
The seekbar thumbnails can initially be empty until the thumbnail images are loaded. But then after the video is playing for a bit (up to 30 seconds or so) the thumbnails show up correctly. Stock YouTube has this same issue. But if the thumbnails never show up then it's a bug. And showing the previous video thumbnails is wrong and definitely a bug. |
What could be happening is that loading the thumbnails fails. Thus, the field that saves it is not being overwritten. In this case, the thumbnails of the previous video are shown in the current one. |
When this bug occurs and it's the first video they are empty and never show no matter what. I have to exit the video and reload it or just watch another video for it to fix |
|
@n1cKz1 The issue may be fixed on dev. Can you try repatching using the latest dev release? https://github.com/ReVanced/revanced-patches/releases/tag/v3.0.0-dev.7 |
|
Looks to be fixed |
This comment was marked as spam.
This comment was marked as spam.
|
With a computer and CLI tools. Search for guides. |
Bug description
When old seekbar thumbnails are enabled, sometimes storyboard fails to fetch properly and as a result an empty thumbnail preview is shown. So far, I've noticed this usually only occurs on the first video watched after launching the app. If you watch another video after that, it starts to work properly.
Steps to repro:
Acknowledgements
The text was updated successfully, but these errors were encountered: