Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(YouTube Music - Hide music video ads): Rename patch name and add description #3378

Closed
3 tasks done
ILoveOpenSourceApplications opened this issue Jun 24, 2024 · 1 comment · Fixed by #3438 or #3494
Closed
3 tasks done

bug(YouTube Music - Hide music video ads): Rename patch name and add description #3378

ILoveOpenSourceApplications opened this issue Jun 24, 2024 · 1 comment · Fixed by #3438 or #3494
Labels
Bug report Something isn't working

Comments

@ILoveOpenSourceApplications
Copy link
Contributor

ILoveOpenSourceApplications commented Jun 24, 2024 •
edited
Loading

Bug description

Currently, Hide music video ads is a not an appropriate name as it not only hides music video ads, but song and podcast ads within YT Music as well.

Error logs

No response

Solution

Rename the patch to Hide media ads and the patch description to "Allows listening to music, podcasts and videos without ads." or "Hides ads played when listening to music, podcasts and videos."

Additional context

No response

Acknowledgements

  • I have checked all open and closed bug reports and this is not a duplicate.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@ILoveOpenSourceApplications ILoveOpenSourceApplications added the Bug report Something isn't working label Jun 24, 2024
This was referenced Jul 30, 2024
Closed
Merged
@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title bug(YouTube Music - Hide music video ads): Rename patch name and description bug(YouTube Music - Hide music video ads): Rename patch name and add description Aug 3, 2024
@ILoveOpenSourceApplications
Copy link
Contributor Author

#3438.

This was linked to pull requests Aug 4, 2024
chore: Merge branch dev to main #3438
Merged
refactor(YouTube Music): Rename Hide music video ads to Hide video ads and add patch description #3494
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug report Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@ILoveOpenSourceApplications