-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(YouTube - Return YouTube Dislike): Dislikes may not be visible when using non English language #44
bug(YouTube - Return YouTube Dislike): Dislikes may not be visible when using non English language #44
Comments
The text clipping is caused by the UI span using a horizontal width that is larger than the width YT measured the text to be. YT measures the text using its own font, and if the device system UI is somehow overriding fonts then the size difference can arise. Are you using a custom font with MIUI? For now, you can try turning on compact layout in RYD, and if that still doesn't fix it then turn on app version spoofing and use target |
Nope
Doesn't seem to help either, i'll have to stick with version spoofing for now |
It's not an issue with MIUI, as I'm able to reproduce the problem on a different device when the system font is set to Greek. It might be something with how YT is measuring Greek text. Using TextView single line would fix any small differences in measurement, as it doesn't clip entire words. |
Yeah just checked as well, dislikes show up fine if I change the language to English |
It's an off by 1 error. Adding just a single pixel to the width calculation fixes it. It's probably a bug in Android. Will fix in a moment. |
Fixed on dev release. You can patch using command line tools, or wait until dev becomes regular release. |
@LisoUseInAIKyrios it's been a few months but I just found out this issue still occurs if compact like button is enabled. Should I create a new issue? |
Yes |
Bug description
Dislikes show up normally on Shorts, but on regular videos there's just an empty space where the dislikes are supposed to be.
This happens on every video with no exceptions. On videos with a bigger dislike count the empty space is larger, which indicates that the dislikes are there, but are simply not visible for whatever reason. Tried: turning off MIUI's forced dark mode in case that affected anything, reinstalling, clearing data etc.
Error logs
Solution
No response
Additional context
According to these logs, it seems the dislikes are fetched normally, so I have zero clue on why they simply aren't visible
Acknowledgements
The text was updated successfully, but these errors were encountered: