Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube - Return YouTube Dislike): Dislikes may not be visible when using non English language #44

Closed
3 tasks done
n1cKz1 opened this issue Dec 3, 2023 · 8 comments · Fixed by ReVanced/revanced-patches-template#3358
Labels
Bug report Something isn't working

Comments

@n1cKz1
Copy link

n1cKz1 commented Dec 3, 2023

Bug description

Dislikes show up normally on Shorts, but on regular videos there's just an empty space where the dislikes are supposed to be.
This happens on every video with no exceptions. On videos with a bigger dislike count the empty space is larger, which indicates that the dislikes are there, but are simply not visible for whatever reason. Tried: turning off MIUI's forced dark mode in case that affected anything, reinstalling, clearing data etc.
Screenshot_2023-12-03-19-12-09-748_app revanced android youtube

Error logs

Voting data fetched:
RYDVoteData{videoId=ez5yuXXAqNg, viewCount=257065, likeCount=5099, dislikeCount=63, likePercentage=0.9877954, dislikePercentage=0.012204572}

Replaced:
'5k' with: '5k ◎ 63' using video: ez5yuXXAqNg

Solution

No response

Additional context

According to these logs, it seems the dislikes are fetched normally, so I have zero clue on why they simply aren't visible

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@n1cKz1 n1cKz1 added the Bug report Something isn't working label Dec 3, 2023
@LisoUseInAIKyrios
Copy link
Contributor

The text clipping is caused by the UI span using a horizontal width that is larger than the width YT measured the text to be.

YT measures the text using its own font, and if the device system UI is somehow overriding fonts then the size difference can arise.

Are you using a custom font with MIUI?

For now, you can try turning on compact layout in RYD, and if that still doesn't fix it then turn on app version spoofing and use target 18.33.40 and that definitely will fix it.

@n1cKz1
Copy link
Author

n1cKz1 commented Dec 3, 2023

Are you using a custom font with MIUI?

Nope

you can try turning on compact layout in RYD

Doesn't seem to help either, i'll have to stick with version spoofing for now

@LisoUseInAIKyrios
Copy link
Contributor

It's not an issue with MIUI, as I'm able to reproduce the problem on a different device when the system font is set to Greek.

It might be something with how YT is measuring Greek text.

Using TextView single line would fix any small differences in measurement, as it doesn't clip entire words.

@n1cKz1
Copy link
Author

n1cKz1 commented Dec 3, 2023

Yeah just checked as well, dislikes show up fine if I change the language to English

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug: (youtube/return-youtube-dislike) dislikes not visible on regular videos bug(YouTube - Return YouTube Dislike): Dislikes may not be visible on when using non English language Dec 3, 2023
@LisoUseInAIKyrios
Copy link
Contributor

It's an off by 1 error. Adding just a single pixel to the width calculation fixes it.

It's probably a bug in Android. Will fix in a moment.

@LisoUseInAIKyrios
Copy link
Contributor

Fixed on dev release.

You can patch using command line tools, or wait until dev becomes regular release.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug(YouTube - Return YouTube Dislike): Dislikes may not be visible on when using non English language bug(YouTube - Return YouTube Dislike): Dislikes may not be visible when using non English language Dec 3, 2023
@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@revanced-bot revanced-bot transferred this issue from another repository Dec 14, 2023
@n1cKz1
Copy link
Author

n1cKz1 commented Mar 31, 2024

@LisoUseInAIKyrios it's been a few months but I just found out this issue still occurs if compact like button is enabled. Should I create a new issue?

@LisoUseInAIKyrios
Copy link
Contributor

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants