Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

class prop should be renamed to a non reserved word #242

Closed
ricardogrw opened this issue Jan 11, 2017 · 2 comments
Closed

class prop should be renamed to a non reserved word #242

ricardogrw opened this issue Jan 11, 2017 · 2 comments

Comments

@ricardogrw
Copy link

Maybe change it to extraClass as you use it in your code?

Of course this is my opinion, feel free to close if needed

Also, your component is pretty awesome 😄
@jonbeller jonbeller mentioned this issue Feb 7, 2017
Merged
@wwayne
Copy link
Collaborator

wwayne commented Feb 8, 2017

Thanks @jonbeller , className option has been added and the old one class has been kept to compatible with previous users

@wwayne wwayne closed this as completed Feb 8, 2017
@ricardogrw
Copy link
Author

Thanks for taking care of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wwayne @ricardogrw