Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example Site Link is Broken #549

Closed
eli-crow opened this issue Feb 6, 2020 · 9 comments
Closed

Example Site Link is Broken #549

eli-crow opened this issue Feb 6, 2020 · 9 comments

Comments

@eli-crow
Copy link

eli-crow commented Feb 6, 2020

Example site link is broken. Thanks for this library!

@aronhelser
Copy link
Collaborator

@Rogger794 the easiest thing may be to use github pages, which would point to http://wwayne.github.io/react-tooltip/ I believe, but it doesn't seem to be set up.
@wwayne I think we need to turn it on in settings, can you do that or give one of us access?

@aronhelser
Copy link
Collaborator

We already have a gh-pages branch, which contains something 😄

@roggervalf
Copy link
Contributor

@aronhelser I would add a codesandbox link for that, maybe that could be a good option.

@roggervalf
Copy link
Contributor

@eli-crow please, check the demo part https://www.npmjs.com/package/react-tooltip

@wwayne
Copy link
Collaborator

wwayne commented Feb 7, 2020

Hi @aronhelser , the demo page is being hosted by Netlify, and Netlify is using the dist folder of the branch gh-pages to set up the demo website.

But since the updates in 2020.1.31, the dist folder has been deleted which broke the demo site, do you know how we get back the dist folder? Thanks.

You can refer the commit history of the branch gh-pages here (I reverted them first so that people can use demo page before we fix it)

@aronhelser
Copy link
Collaborator

yes, so the gh-pages is being updated automatically by CI - on every commit to master (merge commits) the travis commands run, and push the newest changes to gh-pages. @Rogger794 's changes to the build system mean the demo site is not built the same way, so the travis commands need to be updated. Rogger, can you take a look at it? The contents of the 'public' folder in gh-pages is not a complete demo site....

@roggervalf
Copy link
Contributor

@aronhelser I would check it.

@roggervalf
Copy link
Contributor

@eli-crow, there is a link for Github page in the readme now, should be working.

@gregfenton
Copy link

The "example" link on the README page is still not working:

Check example: React-tooltip Test

Since the github and codesandbox links are working, maybe just remove the link to the netlify example site from the README?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants