-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example Site Link is Broken #549
Comments
@Rogger794 the easiest thing may be to use github pages, which would point to http://wwayne.github.io/react-tooltip/ I believe, but it doesn't seem to be set up. |
We already have a gh-pages branch, which contains something 😄 |
@aronhelser I would add a codesandbox link for that, maybe that could be a good option. |
@eli-crow please, check the demo part https://www.npmjs.com/package/react-tooltip |
Hi @aronhelser , the demo page is being hosted by Netlify, and Netlify is using the But since the updates in 2020.1.31, the You can refer the commit history of the branch gh-pages here (I reverted them first so that people can use demo page before we fix it) |
yes, so the gh-pages is being updated automatically by CI - on every commit to master (merge commits) the travis commands run, and push the newest changes to gh-pages. @Rogger794 's changes to the build system mean the demo site is not built the same way, so the travis commands need to be updated. Rogger, can you take a look at it? The contents of the 'public' folder in gh-pages is not a complete demo site.... |
@aronhelser I would check it. |
@eli-crow, there is a link for Github page in the readme now, should be working. |
The "example" link on the README page is still not working:
Since the github and codesandbox links are working, maybe just remove the link to the netlify example site from the README? |
Example site link is broken. Thanks for this library!
The text was updated successfully, but these errors were encountered: