Improve support for server rendering async routes #2883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import Link from '../Link' | ||
| import match from '../match' | ||
| import RoutingContext from '../RoutingContext' |
There was a problem hiding this comment.
This wasn't actually testing the v1 API. Now it is.
|
LGTM. |
|
We initially discussed not doing this in #2036 (comment) and subsequently, but I think this is lightweight enough, and it solves the "async What do you think? |
taion
added a commit
that referenced
this pull request
Jan 13, 2016
Improve support for server rendering async routes
|
👍 |
| } | ||
| // Use initial state from renderProps when available, to allow using match | ||
| // on client side when doing server-side rendering. | ||
| const { location, routes, params, components } = this.props |
There was a problem hiding this comment.
Thank you for this! I just got async routes working with RC4, had some issues, but you fixed it for me :)
👍 @taion
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2714