Added react-is to validate the proptype for Route's component. #6417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed a couple of outdated TODOs that dealt with __DEV__ The rest of the changes were done just from an npm install command React-is does add a tiny bit of size ( https://bundlephobia.com/result?p=react-is@16.5.2 ) as noted by the snapshots, but it seems like the best (and official) way to support the check.
timdorr
approved these changes
Oct 24, 2018
mjackson
reviewed
Oct 25, 2018
| @@ -20,8 +20,6 @@ NativeRouter.defaultProps = { | |||
| } | |||
| }; | |||
|
|
|||
| const __DEV__ = true; // TODO | |||
There was a problem hiding this comment.
We don't actually have a build for react-router-native yet, so we still need this.
There was a problem hiding this comment.
Whoops, my bad. I thought I saw something but I guess I'm wrong 😊 Will fix.
packages/react-router-native/Link.js
Outdated
| @@ -41,8 +41,6 @@ class Link extends React.Component { | |||
| } | |||
| } | |||
|
|
|||
| const __DEV__ = true; // TODO | |||
There was a problem hiding this comment.
We don't actually have a build for react-router-native yet, so we still need this.
|
Updated. Sorry about that! 😊 |
|
Excellent. Thanks, @frehner! :) |
|
Any Idea when this will be available over npm? waiting for this in hope of fix for this issue#172 |
|
Planning on shipping 4.4.0-beta.5 tomorrow with this in it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added react-is to validate the proptype for Route's component.
Removed a couple of outdated TODOs that dealt with
__DEV__The rest of the changes were done just from an
npm installcommandReact-is does add a tiny bit of size ( https://bundlephobia.com/result?p=react-is@16.5.2 ) as noted by the snapshots, but it seems like the best (and official) way to support the check.
Adds the changes and feedback found in #6327 while also removing a duplicated test