Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support line-through and underlining, textDecorationLine on <Text> components #709

Closed
jmcginty opened this issue Sep 22, 2016 · 3 comments
Closed
Labels

Comments

@jmcginty
Copy link
Contributor

The following textDecoration works on ios, but not on Windows.

<Text style={{ textDecorationLine: 'line-through' }} >
          This text should be struck out
</Text>
<Text style={{ textDecorationLine: 'underline' }} >
          This text should be underlined
</Text>

<Text style={{ textDecorationLine: 'underline line-through' }} >
          This text should be underlined and struck out
</Text>

In the react-native doco, textDecorationLine can be one of ..
['none' /default/, 'underline', 'line-through', 'underline line-through'] )

@rozele
Copy link
Collaborator

rozele commented Sep 22, 2016

Thanks @jmcginty. UWP has an "Underline" span type, but does not have a Strikethrough span type. We haven't yet added the underline feature.

@rozele
Copy link
Collaborator

rozele commented Jul 23, 2018

Most of this can be supported as of RS3 with APIs demonstrated in #1723. We just need to update the target and ensure that we do ApiInformation checks to make sure the target is RS3 or later.

@rozele rozele added the .NET label Feb 26, 2019
@chrisglein chrisglein added the .NET Archive Issue opened against deprecated .NET implementation, will be closed (label drives bot activity) label Oct 25, 2019
@ghost
Copy link

ghost commented Oct 25, 2019

We are not investing in new features or lower priority bug fixes on vCurrent. The bulk of investment is now in vNext as we prepare to make that the default choice. If this issue is still relevant on the vNext implementation please open a vNext issue. If this issue is of significant severity for a vCurrent app and vNext is not an option, re-open with justification.

@ghost ghost removed the .NET Archive Issue opened against deprecated .NET implementation, will be closed (label drives bot activity) label Oct 25, 2019
@chrisglein chrisglein added the .NET Archive Issue opened against deprecated .NET implementation, will be closed (label drives bot activity) label Oct 25, 2019
@ghost ghost removed the .NET Archive Issue opened against deprecated .NET implementation, will be closed (label drives bot activity) label Oct 25, 2019
@ghost ghost closed this as completed Oct 25, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants