Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group the logging for the action by interspersing ::group:: lines into the output #223

Closed
michaelkaye opened this issue Feb 16, 2022 · 2 comments

Comments

@michaelkaye
Copy link
Contributor

I'm happy to have a go at doing this but before I spend time I'd like to check if a PR would be accepted.

When i read the action logs sometimes i want to look at the emulator logs and sometimes i want to look at my scripts logs. Grouping these in to a few sections would let me only pop-open the appropriate sections in the logs depending on what i want to see.

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#grouping-log-lines

I was thinking some format along the lines of

> Grouped logs containing options used 
> Grouped logs from installing SDK
> Grouped logs from launching emulator
> Grouped logs from running script
> Grouped logs for teardown

I'd possibly also welcome this format, which focuses on the script that is run.

> Grouped logs containing options used 
> Grouped logs from installing SDK
> Grouped logs from launching emulator
All logs from running script
Because that's what we're here for
So keep logging them in full
> Grouped logs for teardown

Not grouping the script logs would allow end users who want the script to be grouped to do that themselves with their own GHA commands at the start/end of their script.

@ychescale9
Copy link
Member

Thanks, this looks like a good improvement and I'd happily accept a PR! The second one makes sense but I don't have strong opinion here😀

@ychescale9
Copy link
Member

Resolved in #224

@michaelkaye thanks again for the contribution. I'll do a release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants