Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a flatten strategy to limit concurrency #297

Closed
mdiep opened this issue Mar 25, 2017 · 5 comments
Closed

Add a flatten strategy to limit concurrency #297

mdiep opened this issue Mar 25, 2017 · 5 comments
Labels
proposal

Comments

@mdiep
Copy link
Contributor

mdiep commented Mar 25, 2017

concat limits concurrency to 1 signal. merge allows unlimited concurrency. It'd be nice to have something in-between.

ReactiveObjC has this as flatten:.

This is useful for things like Carthage/Carthage#1841.
@NachoSoto
Copy link
Member

Or change .merge to .merge(maxConcurrency: UInt) with static let merge: FlattenStrategy = .Merge(UInt.max).

@mdiep
Copy link
Contributor Author

mdiep commented Mar 25, 2017

And static let concat = .merge(1)?

@NachoSoto
Copy link
Member

As long as it's not less performance, merging (no pun intended) the implementations would be amazing.

@andersio
Copy link
Member

andersio commented Mar 27, 2017 •
edited
Loading

I'd call it thebound or concurrent strategy. 🙂

@andersio andersio mentioned this issue Mar 28, 2017
Merged
1 task
@andersio
Copy link
Member

andersio commented Apr 5, 2017

Implemented in #298.

@andersio andersio closed this as completed Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mdiep @NachoSoto @andersio