fix(umd): fix the UMD bundle export names so they don't conflict and overwrite each other #318

trxcllnt · 2021-01-26T07:33:00Z

Importing multiple UMD bundles into the same page was causing the global Ix object to be replaced
each time, rather than augmented. Exporting them to distinct global objects based on the file name
causes them not to conflict.

Here's an example of something that would currently conflict. Depending on which file was imported, either from or flatMap wouldn't be available:

<!DOCTYPE html>
<html><body>
<script src="/targets/esnext/umd/Ix.dom.asynciterable.js"></script>
<script src="/targets/esnext/umd/Ix.dom.asynciterable.operators.js"></script>
<script type="text/javascript">
const { from } = IxAsynciterable;
const { flatMap } = IxAsynciterableOperators;
from([0, 1, 2])
  .pipe(flatMap((x) => [x + 1]))
  .forEach((x) => console.log(x))
</script>
</body></html>

…overwrite each other Importing multiple UMD bundles into the same page was causing the global Ix object to be replaced each time, rather than augmented. Exporting them to distinct global objects based on the file name causes them not to conflict.

trxcllnt merged commit c45eaa8 into master Jan 26, 2021

trxcllnt deleted the fix/umd-export-names branch January 26, 2021 08:03

dependabot bot mentioned this pull request Mar 16, 2021

Bump ix from 4.0.0 to 4.3.0 david-driscoll/DynamicDataJs#293

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(umd): fix the UMD bundle export names so they don't conflict and overwrite each other #318

fix(umd): fix the UMD bundle export names so they don't conflict and overwrite each other #318

trxcllnt commented Jan 26, 2021 •

edited

Loading

fix(umd): fix the UMD bundle export names so they don't conflict and overwrite each other #318

fix(umd): fix the UMD bundle export names so they don't conflict and overwrite each other #318

Conversation

trxcllnt commented Jan 26, 2021 • edited Loading

trxcllnt commented Jan 26, 2021 •

edited

Loading