-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build errors with Typescript 4.7.4 #345
Comments
Looks like there are more errors with 5.3.2. I get this error in a downstream project
|
Could you make a new release so that we get this fix in arrow? |
@domoritz yes I can |
Great, let me know and I'll update the dependency in arrow to remove the type errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
IxJS version: 4.5.2
Code to reproduce:
Using
@reactivex/ix-ts
in webpack (4) with fork-ts-checker-webpack-plugin (6) and Typescript (4.7.4).tsconfig.json excerpt:
Expected behavior:
Compiles without errors originating in
node_modules/@reactivex/ix-ts
.Actual behavior:
Additional information:
The two
toNodeStream
errors are wrapped inif (isBrowser)
blocks so it looks like a simple type leakage from a node lib? Maybe just needs anas any
to avoid assuming Node types are available? (Or// @ts-ignore
; I don't know how that combines with// prettier-ignore
, though.)The withabort error seems like a simple type fix, perhaps:
Comparing this operator version with the non-operator version in asynciterablex.ts it looks like the difference is instead a
// @ts-ignore
above the currently erroring line.The text was updated successfully, but these errors were encountered: