-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HandlerScheduler.scheduleDirect supports async option? #441
Comments
Hmm, that's a good shout. It'd be nicer if we could just use the hidden constructor of Handler to enable this at the handler level, but that implementation looks fine too. Looks like this affects all the observe/subscribe/dispose-"on" operators as well @JakeWharton @adamp thoughts? |
I'd rather do the simple thing. I was hoping the recent release would be the last. Maybe this one will stick... |
Consistency looks good to me. |
thx reply! Handler level async can use from API28 via I think that it is unnatural not to consider async option in I opened PR, If there is no problem please review it. |
RxAndroid support async option v2.1.0. now, it support only in
HandlerWorker.schedule
.I think,
HandlerScheduler.scheduleDirect
should be support async option.Because, some RxJava operator use
Scheduler.scheduleDirect
method (ex, Maybe.observeOn)(i prepared source code in 2.x...satoshun:2.x)
The text was updated successfully, but these errors were encountered: