Skip to content

Commit

Permalink
fix(inspect): remove inspect and inspectTime operators
Browse files Browse the repository at this point in the history
Remove inspect and inspectTime operators from this library, since they are unnecessary and don't
exist in previous versions of RxJS.

This change was suggested in issue #1053.

BREAKING CHANGE:
`inspect` and `inspectTime` were removed. Use `withLatestFrom` instead.
  • Loading branch information
staltz authored and kwonoj committed Dec 22, 2015
1 parent 0f38730 commit 17341a4
Show file tree
Hide file tree
Showing 8 changed files with 0 additions and 395 deletions.
180 changes: 0 additions & 180 deletions spec/operators/inspect-spec.js

This file was deleted.

99 changes: 0 additions & 99 deletions spec/operators/inspectTime-spec.js

This file was deleted.

2 changes: 0 additions & 2 deletions src/Observable.ts
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,6 @@ export class Observable<T> implements CoreOperators<T> {
elementSelector?: (value: T) => R,
durationSelector?: (group: GroupedObservable<R>) => Observable<any>) => Observable<GroupedObservable<R>>;
ignoreElements: () => Observable<T>;
inspect: (notifier: Observable<any>) => Observable<T>;
inspectTime: (delay: number, scheduler?: Scheduler) => Observable<T>;
last: <R>(predicate?: (value: T, index: number) => boolean,
resultSelector?: (value: T, index: number) => R,
defaultValue?: any) => Observable<T> | Observable<R>;
Expand Down
4 changes: 0 additions & 4 deletions src/Rx.KitchenSink.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ export interface KitchenSinkOperators<T> extends CoreOperators<T> {
distinctUntilKeyChanged?: (key: string, compare?: (x: any, y: any) => boolean) => Observable<T>;
find?: (predicate: (value: T, index: number, source: Observable<T>) => boolean, thisArg?: any) => Observable<T>;
findIndex?: (predicate: (value: T, index: number, source: Observable<T>) => boolean, thisArg?: any) => Observable<number>;
inspect?: (notifier: Observable<any>) => Observable<T>;
inspectTime?: (delay: number, scheduler?: IScheduler) => Observable<T>;
max?: <T, R>(comparer?: (x: R, y: T) => R) => Observable<R>;
min?: <T, R>(comparer?: (x: R, y: T) => R) => Observable<R>;
timeInterval?: <T>(scheduler?: IScheduler) => Observable<T>;
Expand Down Expand Up @@ -76,8 +74,6 @@ import './add/operator/finally';
import './add/operator/first';
import './add/operator/groupBy';
import './add/operator/ignoreElements';
import './add/operator/inspect';
import './add/operator/inspectTime';
import './add/operator/isEmpty';
import './add/operator/every';
import './add/operator/last';
Expand Down
5 changes: 0 additions & 5 deletions src/add/operator/inspect.ts

This file was deleted.

5 changes: 0 additions & 5 deletions src/add/operator/inspectTime.ts

This file was deleted.

55 changes: 0 additions & 55 deletions src/operator/inspect.ts

This file was deleted.

Loading

0 comments on commit 17341a4

Please sign in to comment.