-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build_docs): fix doc building #1974
fix(build_docs): fix doc building #1974
Conversation
Did you check that those |
f822312
to
7d6e9f6
Compare
7d6e9f6
to
d89d6b1
Compare
This now appears to build and "hide" for me. I don't see the hidden classes in the generated docs. |
Ok, I trust your judgement then. |
LGTM |
I don't have write access to merge this. Is there anything else to do on my end prior to merging this? |
No, just wait. Thanks :) |
Once |
I think it makes sense to update PR freely to address additional issue you'd like to update. |
I'll try to get this rebased and merged soon. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description:
npm run build_docs
was not working for me. I was missing the escape regular expression dependency and the@hide
tag was no longer working for me when the custom plug-in would attempt to parse it. I replaced@hide
with the esdoc@ignore
tag.