Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build_docs): fix doc building #1974

Merged

Conversation

bafolts
Copy link
Contributor

@bafolts bafolts commented Sep 24, 2016

Description:

npm run build_docs was not working for me. I was missing the escape regular expression dependency and the @hide tag was no longer working for me when the custom plug-in would attempt to parse it. I replaced @hide with the esdoc @ignore tag.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.062% when pulling 3def08a on bafolts:static-observable-merge-docs-update into e20cdb7 on ReactiveX:master.

@staltz
Copy link
Member

staltz commented Sep 25, 2016

Did you check that those We need this JSDoc comment for affecting ESDoc. JSDocs did not appear in the generated documentation?

@bafolts bafolts force-pushed the static-observable-merge-docs-update branch 2 times, most recently from f822312 to 7d6e9f6 Compare September 25, 2016 19:39
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.062% when pulling 7d6e9f6 on bafolts:static-observable-merge-docs-update into e20cdb7 on ReactiveX:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.062% when pulling 7d6e9f6 on bafolts:static-observable-merge-docs-update into e20cdb7 on ReactiveX:master.

@bafolts bafolts force-pushed the static-observable-merge-docs-update branch from 7d6e9f6 to d89d6b1 Compare September 25, 2016 19:45
@bafolts
Copy link
Contributor Author

bafolts commented Sep 25, 2016

This now appears to build and "hide" for me. I don't see the hidden classes in the generated docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.062% when pulling d89d6b1 on bafolts:static-observable-merge-docs-update into e20cdb7 on ReactiveX:master.

@staltz
Copy link
Member

staltz commented Sep 26, 2016

Ok, I trust your judgement then.

@staltz
Copy link
Member

staltz commented Sep 26, 2016

LGTM

@bafolts
Copy link
Contributor Author

bafolts commented Sep 27, 2016

I don't have write access to merge this. Is there anything else to do on my end prior to merging this?

@staltz
Copy link
Member

staltz commented Sep 27, 2016

No, just wait. Thanks :)

@bafolts
Copy link
Contributor Author

bafolts commented Sep 27, 2016

Once npm run build_docs runs for me I get errors about mismatched parameters which I was also going to address and change some of the spread parameters to be spread parameters instead of input1, input2, should I use this PR for those changes?

@kwonoj
Copy link
Member

kwonoj commented Sep 27, 2016

I think it makes sense to update PR freely to address additional issue you'd like to update.

@benlesh
Copy link
Member

benlesh commented Oct 10, 2016

I'll try to get this rebased and merged soon.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.041% when pulling 65bfaea on bafolts:static-observable-merge-docs-update into ece1b89 on ReactiveX:master.

@coveralls
Copy link

coveralls commented Oct 24, 2016

Coverage Status

Coverage remained the same at 97.041% when pulling 65bfaea on bafolts:static-observable-merge-docs-update into ece1b89 on ReactiveX:master.

@jayphelps jayphelps merged commit 1bbbe8b into ReactiveX:master Oct 24, 2016
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants