Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rc4 compilation failure with operator/distinctKey #2161

Closed
alexeagle opened this issue Nov 29, 2016 · 3 comments
Closed

rc4 compilation failure with operator/distinctKey #2161

alexeagle opened this issue Nov 29, 2016 · 3 comments

Comments

@alexeagle
Copy link
Contributor

src/add/operator/distinctKey.ts(2,29): error TS2307: Cannot find module '../../operator/distinctKey'
@Brooooooklyn
Copy link
Contributor

distinctKey was removed 89612b2

alexeagle referenced this issue Nov 30, 2016
@benlesh @jayphelps
feat(distinct): remove distinctKey, distinct signature change and…
89612b2 
… perf improvements (#2049)

* feat(distinct): remove `distinctKey`,  `distinct` signature change and perf improvements

- Adds a limited Set ponyfill for runtimes that do not support `Set`
- `distinct` now supports an optional keySelector argument that the user can use to select the value to check distinct on
- `distinctKey` is removed as it is redundant
- `distinct` no longer supports a comparer function argument, as there is little to no use case for such an argument that could not be covered by the keySelector
- updates tests to remove tests that do not make sense and test new functionality

BREAKING CHANGE: `distinctKey` has been removed. Use `distinct`
BREAKING CHANGE: `distinct` operator has changed, first argument is an
optional `keySelector`. The custom `compare` function is no longer
supported.

resolves #2009

* perf(distinct): increase `distinct()` perf by improving deopts

- moves keySelector call to a different function with a try catch to improve V8 optimization
- distinct calls with no keySelector passed now take a fully optimized path, doubling speed again

related #2009

* docs(distinct): update distinct docs to fit new API
@jayphelps
Copy link
Member

jayphelps commented Nov 30, 2016 •
edited
Loading

We forgot to remove the file https://github.com/ReactiveX/rxjs/blob/c7cfe444642407f3227a09a0cdf38fd495b867e1/src/add/operator/distinctKey.ts

PR to fix coming shortly.

Thanks @alexeagle ! any idea why our internal build didn't fail? Is there an option we can enable to be more strict?

jayphelps added a commit to jayphelps/rxjs that referenced this issue Nov 30, 2016
@jayphelps
fix(distinctKey): Remove accidentally leftovers of distinctKey
c5c75cf 
`distinctKey` was removed in the previous version but we accidentally
left some files and references to it, which can cause build failures for
TS users.

fixes ReactiveX#2161
jayphelps added a commit to jayphelps/rxjs that referenced this issue Nov 30, 2016
@jayphelps
fix(distinctKey): Removed accidental leftover reference of distinctKey
9fd8096 
`distinctKey` was removed in the previous version but we accidentally
left some files and references to it, which can cause build failures for
TS users.

fixes ReactiveX#2161
@jayphelps jayphelps mentioned this issue Nov 30, 2016
Merged
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexeagle @jayphelps @Brooooooklyn