Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(race): support array of observables other than rest param #2548

Merged
merged 1 commit into from
May 3, 2017

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Apr 11, 2017

Description:
I just noticed Observable.race([o1, o2]) is not working cause current definition is shaped for rest param args only (so Observable.race(...[o1, o2]) works. This PR aligns type definition to support those forms to actual operator behavior.

Related issue (if exists):

@kwonoj kwonoj requested a review from david-driscoll April 11, 2017 17:19
@kwonoj
Copy link
Member Author

kwonoj commented Apr 11, 2017

I guess this is patch as it won't breaking existing behavior? (...while I'm currently bad at picking right version for changes though)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 97.702% when pulling 47f15dd on kwonoj:type-race into dc2e7f1 on ReactiveX:master.

@kwonoj
Copy link
Member Author

kwonoj commented Apr 11, 2017

uh..one another thing -

const o1 = Observable.of(1);
const b = Observable.race(o1, o1); //b is inferred to Observable<any> instead of Observable<number>?

Copy link
Member

@benlesh benlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to change the commit message to be fix(race): allow TypeScript support for ... ... the feature is there, the typings are not

@kwonoj
Copy link
Member Author

kwonoj commented Apr 12, 2017

Updated commit message.

@coveralls
Copy link

coveralls commented Apr 12, 2017

Coverage Status

Coverage increased (+0.01%) to 97.702% when pulling 47f15dd on kwonoj:type-race into dc2e7f1 on ReactiveX:master.

@benlesh benlesh merged commit ace553c into ReactiveX:master May 3, 2017
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
@kwonoj kwonoj deleted the type-race branch October 4, 2019 05:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants