fix(partition): update signature to match docs and filter operator

[manbearwiz]

Description:

This PR adds the index parameter to the predicate signature for the partition operator. This change matches the docs as well as the existing filter operator.

[kwonoj]

Interesting, it seems like we had signature to support index but removed it for some reason, not sure why.

Still, it already makes current public api surface as-is, means if we make index as non-optional param, it'll be breaking changes for next major instead of minor. (next branch.) For me it seems more feasible to make index to optional.

[kwonoj]

/cc @david-driscoll as well.

[manbearwiz]

Yah I saw the commit that removed it but assumed it was removed on accident.

As for it being a surface api change, it may not matter in this case. There is no change in the way the predicate is called in the filter operator so if the given predicate does not have the index in its signature it will just be ignored. All of the existing tests in the spec show this.

[rxjs-bot]

	Messages
📖

CJS: 3735.2KB, global: 707.3KB (gzipped: 133.8KB), min: 140.2KB (gzipped: 30.0KB)

Generated by 🚫 dangerJS

[coveralls]

Coverage remained the same at 97.395% when pulling 2460114 on manbearwiz:patch-1 into d926435 on ReactiveX:master.

[benlesh]

I'm not sure this is a breaking change, @kwonoj.(x: T) => R is compatable with (x: T, i: number) => R as an argument.

[kwonoj]

yeah, I think I misread signatures.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.