Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shareReplay): no longer exporting function unnecessarily #2928

Merged
merged 1 commit into from
Oct 10, 2017
Merged

fix(shareReplay): no longer exporting function unnecessarily #2928

merged 1 commit into from
Oct 10, 2017

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Oct 9, 2017

As @kwonoj mentioned in the other PR, #2924, we don't need to export that the operator function.

@benlesh benlesh requested a review from kwonoj October 9, 2017 17:02
@rxjs-bot
Copy link

rxjs-bot commented Oct 9, 2017

Messages
📖

CJS: 1346.2KB, global: 745.4KB (gzipped: 139.9KB), min: 145.4KB (gzipped: 30.8KB)

Generated by 🚫 dangerJS

@coveralls
Copy link

coveralls commented Oct 9, 2017

Coverage Status

Coverage decreased (-0.0004%) to 97.411% when pulling 61103cc on benlesh:shareReplay_dont_export_that into 3d9cf87 on ReactiveX:master.

@benlesh benlesh merged commit e159578 into ReactiveX:master Oct 10, 2017
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants