From 281d411ff0de2234e2ae86f0b75cf755b4ea190b Mon Sep 17 00:00:00 2001 From: Sadegh Kazemy Date: Sat, 11 Nov 2017 08:37:52 +0330 Subject: [PATCH 1/2] Add a sentence to documentation of take() operator --- src/main/java/rx/Observable.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/main/java/rx/Observable.java b/src/main/java/rx/Observable.java index 4b3d7802b4..1de0bfd704 100644 --- a/src/main/java/rx/Observable.java +++ b/src/main/java/rx/Observable.java @@ -10535,6 +10535,8 @@ public final Observable take(final int count) { /** * Returns an Observable that emits those items emitted by source Observable before a specified time runs * out. + * If time runs out before Observable is finished, termination events would be called on provided {@link Scheduler}, + + which is {@code computation} by default. *

* *

@@ -10559,6 +10561,8 @@ public final Observable take(long time, TimeUnit unit) { /** * Returns an Observable that emits those items emitted by source Observable before a specified time (on a * specified Scheduler) runs out. + * If time runs out before Observable is finished, termination events would be called on provided {@link Scheduler}, + + which is {@code computation} by default. *

* *

From 24bb5cabfe503c93d21f2a0918d242f225457e70 Mon Sep 17 00:00:00 2001 From: Sadegh Kazemy Date: Sat, 11 Nov 2017 14:45:08 +0330 Subject: [PATCH 2/2] Rephrase java doc for take() method --- src/main/java/rx/Observable.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/main/java/rx/Observable.java b/src/main/java/rx/Observable.java index 1de0bfd704..5d1896008e 100644 --- a/src/main/java/rx/Observable.java +++ b/src/main/java/rx/Observable.java @@ -10535,8 +10535,9 @@ public final Observable take(final int count) { /** * Returns an Observable that emits those items emitted by source Observable before a specified time runs * out. - * If time runs out before Observable is finished, termination events would be called on provided {@link Scheduler}, - + which is {@code computation} by default. + *

+ * If time runs out before the {@code Observable} completes normally, the {@code onComplete} event will be + * signaled on the default {@code computation} {@link Scheduler}. *

* *

@@ -10561,8 +10562,9 @@ public final Observable take(long time, TimeUnit unit) { /** * Returns an Observable that emits those items emitted by source Observable before a specified time (on a * specified Scheduler) runs out. - * If time runs out before Observable is finished, termination events would be called on provided {@link Scheduler}, - + which is {@code computation} by default. + *

+ * If time runs out before the {@code Observable} completes normally, the {@code onComplete} event will be + * signaled on the provided {@link Scheduler}. *

* *