-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observable.retry and Observable.retryWith memory leak in Zone.js #1400
Comments
So for the same reasons I'm closing #1391 I'm closing this Issue. See comment here for more detail: #1391 (comment) TL;DR: This was an issue with zone.js that is fixed in zone.js and awaiting integration into Angular 2. |
cc/ @mhevery |
The reason why Zone.js has a memory leak is that it forks on each async task, which eventually runs out of memory. As of this morning Zone.js has been rewritten, and the memory leak removed, so it should no longer be an issue. |
@mhevery Great! Do you have any idea when it will be integrated into ng2? |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
@trxcllnt I have found another memory leak in Angular's Zone.js (I assume) when using Observable.retry and Observable.retryWith. This memory leak is there even after implementing your PR #1395. See my repo. I have tested the issue and confirmed that it does not leak whenever it is used in isolation, so it must be going through some loops like Observable.interval that Zone.js is tracking. Do you know of the internals off the top of your head as to reasons I might be having the leak with these operators?
Reference:
#1391
#1394
#1395
Thanks,
The text was updated successfully, but these errors were encountered: