Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration collection not in 6.0.0-terrific-rc.3 release #3550

Closed
cexbrayat opened this issue Apr 11, 2018 · 3 comments
Closed

Migration collection not in 6.0.0-terrific-rc.3 release #3550

cexbrayat opened this issue Apr 11, 2018 · 3 comments
Labels
bug Confirmed bug

Comments

@cexbrayat
Copy link

RxJS version:

6.0.0-terrific-rc.3

Code to reproduce:

Using CLI 6.0.0-rc.3
Bump RxJS to 6.0.0-terrific-rc.3
Then run ng update rxjs --migrate-only --from=5.5.8

Expected behavior:

It should run the migration schematic

Actual behavior:

It throws Collection "rxjs/./migrations/collection.json" cannot be resolved.

Additional information:

It's entirely possible that I am missing something, or that this is a CLI issue, but it looks like node_modules/rxjs does not contain the migrations folder. I know the support of migration is very experimental, but maybe there is a missing piece in the RxJS release to integrate the migrations folder...

@cexbrayat
Copy link
Author

I confirm that the migration script is now included

But, FYI, using CLI 6.0.0-rc.4, I'm now running into: Cannot find module '/Users/cedric/Code/ninjasquad/ng2propack/frontend/node_modules/rxjs/migrations/update-6_0_0/index'.

Which is maybe more a CLI issue? Because the update-6_0_0 folder does contain index.ts...

@cexbrayat
Copy link
Author

@benlesh 👍 Fixed in rc.7.

@lock
Copy link

lock bot commented Jun 5, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Confirmed bug
Projects
None yet
Development

No branches or pull requests

2 participants