Websocket Serialization error not shown

[s4m0r4m4]

Bug Report

Current Behavior
When an error is thrown/encountered in the function provided as the "serializer" in the WebsocketSubjectConfig object, this error gets silently swallowed and then the websocket connection fails.

Reproduction

Here is a stackblitz repro, except I didn't have a public websocket to test with. If you have any recommendations I'd gladly update the repro.
https://stackblitz.com/edit/angular-ivy-hxp2ht

Expected behavior
The error should make its way back to the error subscription.

Environment

• Node v12.16.1
• RxJS version: 6.5.5
• Angular: 9.1.3

Possible Solution

Unknown

[s4m0r4m4]

Hi I'm just checking in on this - perhaps there's a way to handle such errors that I'm not aware of?

[elpddev]

Hi @s4m0r4m4 . I'm not a maintainer, just looking. The relevant code maybe this:

rxjs/src/internal/observable/dom/WebSocketSubject.ts

Line 294 in 7803215

try {

In any case, you could always provide 1->1 custom serializer to the config and serialize the message before hand. What I do in those cases is for example:

function streamSend() {
  const streamFn = () => sendAction.pipe(
     map(data => serializeData(data)),
     tap(dataStr => webSocket$.next(dataStr)),
     catchError((err) =>{
        logError(err);
        return streamFn()
     })
  );
  
  return streamFn();
}

streamSend().pipe(takeUntil(...)).subscribe();

[bever1337]

Related bugs: #5312 #6848