Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observable docs are confusing #7310

Closed
skelly-energid opened this issue Jul 19, 2023 · 2 comments
Closed

Observable docs are confusing #7310

skelly-energid opened this issue Jul 19, 2023 · 2 comments

Comments

@skelly-energid
Copy link

Describe the bug

The docs at https://rxjs.dev/guide/observable explain how to use new Observable with arrow functions.

Later the docs exclaim

"It is not a coincidence that observable.subscribe and subscribe in NEVER BEFORE SEEN PATTERN have the same name."

the never-before-seen-pattern could be a remnant of a previous iteration of the docs which did use the pattern instead of arrow functions above. If that's the case then this should be removed because it is confusing.

Expected behavior

Not-confusing docs

Reproduction code

No response

Reproduction URL

No response

Version

latest

Environment

No response

Additional context

No response

@voliva
Copy link
Contributor

voliva commented Jul 20, 2023

The first example in creating observables, which is just above the line you are referring to, is using the function "pattern".

And RxJS doesn't really care if you use function or arrow functions either, so that's completely irrelevant.

@kwonoj kwonoj closed this as completed Jul 20, 2023
@skelly-energid
Copy link
Author

As far as I can tell, the name is irrelevant. Is that correct? If it's irrelevant, then the confusing line should just be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants