Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix missing overloads in docs when overload count is less than 3 #7369

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

tmair
Copy link
Contributor

@tmair tmair commented Oct 30, 2023

Description:
This PR fixes the display of overloads in the docs application if there are less than 3 overloads.

Backport of: #7367

Related issue (if exists): #5281

Copy link
Member

@jakovljevic-mladen jakovljevic-mladen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jakovljevic-mladen
Copy link
Member

@benlesh, now we're running into issue where CI fails on 7.x branch. Error:

npm ERR! notsup Required: {"node":"^18.17.0 || >=20.5.0"}
npm ERR! notsup Actual:   {"npm":"8.19.4","node":"v16.20.2"}

How do we solve this?

BTW, change from this PR does not impact in any way anything that is tested during CI run, so I will probably merge it later. Just want to make sure you know that we're having issues with CI run.

@benlesh
Copy link
Member

benlesh commented Oct 30, 2023

How do we solve this?

I'm not quite sure yet. I'll look into it. In the meantime, I think this can be merged.

@benlesh benlesh merged commit d69d890 into ReactiveX:7.x Oct 30, 2023
0 of 4 checks passed
@benlesh
Copy link
Member

benlesh commented Oct 30, 2023

@tmair thank you for this PR! BTW (and this isn't a big deal). When doing anything on the docs site, even if it's a "fix", just use docs: whatever the change is for the message. fix(???): ??? will show up in the library's changelog.

@tmair tmair deleted the fix-overload-docs-v7 branch October 30, 2023 14:39
@tmair
Copy link
Contributor Author

tmair commented Oct 30, 2023

@tmair thank you for this PR! BTW (and this isn't a big deal). When doing anything on the docs site, even if it's a "fix", just use docs: whatever the change is for the message. fix(???): ??? will show up in the library's changelog.

Oh, I was not aware of this. I will try to remember this for any future PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants