-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pipe): signature for arbitrary array of T->T operations #7394
Conversation
Hi @ whoever approved the pipeline the issue is not mine but something with the pipeline
|
I think the updated CI rules for our master branch are conflicting with this branch. We'll take a look soon. |
All current issues on the 7.x branch relate to the same problem - the code has stayed the same, but it is trying to be run with tooling which has since evolved. This PR fixes the existing issues: If @benlesh agrees with the rationale/approach it can be merged before this one and this one rebased on top |
Yeah if you rebase, everything will run now. Thank you, @JamesHenry . |
Let's try the pipeline again 🙂 |
This time 🚀 |
Let's run it once more 🙂 @benlesh |
Time to run it locally and wait for npm... I had aborted the clone at 100MB and hoped the code would work out of the box. Sorry for the inconvenience. |
Now; success guaranteed 🙂 |
We'll need to have the same PR merged to master first, or it's technically a regression. (if 7.x supports this but 8.x does not) |
Are these types still an issue with 8.x? |
Description:
Sometimes, you have an array of
MonoTypeOperatorFunction<T>
(e.g. a list of independent filters), and currently the only way of doing this is as follows:This PR adds an additional signature for this use-case.
Related issue:
Maybe #3989