You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The usual approach to configurations is to use the options object, as this can be set for all targets, and then optionally overridden in specific targets. i.e. given:
// https://github.com/RealFaviconGenerator/grunt-real-favicon
real_favicon: {favicons: {src: '<%= paths.authorAssets %>images/dt-logo-circle.png',dest: '<%= paths.authorAssets %>images/favicons-generated/',html: [],design: {ios: {picture_aspect: 'no_change'},windows: {picture_aspect: 'no_change',background_color: '#2b5797'// One of the recommended Windows UI colors}},settings: {compression: 2}}};
I'd expect it to be more like:
real_favicon: {options: {html: [],ios: {picture_aspect: 'no_change'},windows: {picture_aspect: 'no_change',background_color: '#2b5797'// One of the recommended Windows UI colors},compression: 2},favicons: {src: '<%= paths.authorAssets %>images/dt-logo-circle.png',dest: '<%= paths.authorAssets %>images/favicons-generated/',}};
...which would then allow easier overriding, such as:
real_favicon: {options: {html: [],ios: {picture_aspect: 'no_change'},windows: {picture_aspect: 'no_change',background_color: '#2b5797'// One of the recommended Windows UI colors},compression: 2},theme1: {src: '<%= paths.authorAssets %>images/dt-logo-circle.png',dest: '<%= paths.authorAssets %>images/favicons-theme1/',},theme2: {options: {windows: {background_color: '#000000'}},src: '<%= paths.authorAssets %>images/dt-logo-circle.png',dest: '<%= paths.authorAssets %>images/favicons-theme2/',}};
I realise this is going to be backwards-incompatible, but it would bring it more inline with how the majority of Grunt tasks are written.
The text was updated successfully, but these errors were encountered:
The usual approach to configurations is to use the
options
object, as this can be set for all targets, and then optionally overridden in specific targets. i.e. given:I'd expect it to be more like:
...which would then allow easier overriding, such as:
I realise this is going to be backwards-incompatible, but it would bring it more inline with how the majority of Grunt tasks are written.
The text was updated successfully, but these errors were encountered: