Unable to generate favicon from SVG

[mzrnsh]

Hi. Using this gem on Rails 6.

I just tried to run the generator on a SVG file. On the website this file had no issues. However the generator timed out a couple of times. Fed it the PNG version of the same file and worked like charm.

Is this an issue or was this gem never supposed to work with SVGs? If the latter, maybe the uploader should not accept SVG files to avoid confusion

[MyklClason]

I have seen the timeout issue, you can increase the time allowed. This is actually a Rails restriction I think.

rails generate favicon -t 100 for 100 seconds as per the error message instructions. Depending on things like master image size and the options selected you may need to go much higher, such as 300 seconds (5 minutes) or even 3600 seconds (1 hour). Though 100 seconds was enough for me, but I used a PNG. If it works on the site, I assume it works on the page, just needs enough time.

I'm fairly sure this gem is basically just doing this:

1. Upload image to the generator site
2. Let generator generate files (same thing that happens when you upload the files)
3. Download images
4. Save images and config files

Depending on your internet speed and the file sizes, 1-3 can take a significant amount of time.

It would be nice if we could see some sort of progress indicator, and perhaps an estimated time to completion. Even if it's just "Uploading files...", "Processing...", "Downloading files..", "Saving Files", "Generating Config". Since it's remote I don't think we can get much more without them doing API work on the generator site.