From 56a190eb7249882ccc1c75f73770d878b0c8e4cb Mon Sep 17 00:00:00 2001
From: Splidge <anything@dchilvers.com>
Date: Wed, 25 Aug 2021 10:53:21 +0100
Subject: [PATCH] better `minPriceIncreaseCalc`

---
 contracts/RCMarket.sol | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/contracts/RCMarket.sol b/contracts/RCMarket.sol
index 7f3e4cca..f3da2760 100644
--- a/contracts/RCMarket.sol
+++ b/contracts/RCMarket.sol
@@ -694,22 +694,13 @@ contract RCMarket is Initializable, NativeMetaTransaction, IRCMarket {
         // check that not being front run
         uint256 _actualSumOfPrices = 0;
         for (uint256 i = 0; i < numberOfCards; i++) {
-            if (card[i].cardPrice == 0) {
-                _actualSumOfPrices += MIN_RENTAL_VALUE;
-            } else {
-                _actualSumOfPrices += minPriceIncreaseCalc(card[i].cardPrice);
-            }
+            _actualSumOfPrices += minPriceIncreaseCalc(card[i].cardPrice);
         }
         require(_actualSumOfPrices <= _maxSumOfPrices, "Prices too high");
 
         for (uint256 i = 0; i < numberOfCards; i++) {
             if (ownerOf(i) != msgSender()) {
-                uint256 _newPrice;
-                if (card[i].cardPrice > 0) {
-                    _newPrice = minPriceIncreaseCalc(card[i].cardPrice);
-                } else {
-                    _newPrice = MIN_RENTAL_VALUE;
-                }
+                uint256 _newPrice = minPriceIncreaseCalc(card[i].cardPrice);
                 newRental(_newPrice, 0, address(0), i);
             }
         }
@@ -1130,7 +1121,11 @@ contract RCMarket is Initializable, NativeMetaTransaction, IRCMarket {
         view
         returns (uint256 _newPrice)
     {
-        _newPrice = (_oldPrice * (minimumPriceIncreasePercent + 100)) / 100;
+        if (_oldPrice == 0) {
+            return MIN_RENTAL_VALUE;
+        } else {
+            return (_oldPrice * (minimumPriceIncreasePercent + 100)) / 100;
+        }
     }
 
     /*╔═════════════════════════════════╗