You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using betting amounts higher than half of the (positive) integer limit, the payout amount will overflow to a negative number.
In this example 1,500,000,000.00 was used as wager:
An easy fix would be changing all integers in the plugin to doubles, as this is what vault is using and they have a much higher maximum value. As an extra precaution, I would add a configurable maximum betting amount.
The text was updated successfully, but these errors were encountered:
When using betting amounts higher than half of the (positive) integer limit, the payout amount will overflow to a negative number.
In this example 1,500,000,000.00 was used as wager:
![afbeelding](https://private-user-images.githubusercontent.com/39677806/264179038-24369a5a-4f71-4832-a0ae-1b5f369afca0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5NDE2NDUsIm5iZiI6MTcyNTk0MTM0NSwicGF0aCI6Ii8zOTY3NzgwNi8yNjQxNzkwMzgtMjQzNjlhNWEtNGY3MS00ODMyLWEwYWUtMWI1ZjM2OWFmY2EwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEwVDA0MDkwNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdkYTEyYmMwMzI0Y2RjOTM2MGU3NjIzNjVhZmQyZmU4OWYzODhhZmFhZDAxMmQ3NTg2OGY1N2FkMTIxYzEwNmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.UetcF2aItdisUiRPUfsSNCizF-SLlqr3vbVlnq0yKD8)
An easy fix would be changing all integers in the plugin to doubles, as this is what vault is using and they have a much higher maximum value. As an extra precaution, I would add a configurable maximum betting amount.
The text was updated successfully, but these errors were encountered: