-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][#67] Adds tslint autofix as a flag to ForkTsCheckerWebpackPlugin plugin #174
[Feature][#67] Adds tslint autofix as a flag to ForkTsCheckerWebpackPlugin plugin #174
Conversation
@johnnyreilly Changes for adding auto fix as a flag. Let me know if I had missed anything. |
Thanks for this! @piotr-oles what's your feeling on merging this? It's not a feature that I would use but clearly there's some demand out there for this. I know you expressed reservations so I don't want to merge unless I know you're okay with this! |
Thank you @ajainarayanan for your work! I was afraid that it will add complexity to the plugin but looks like it doesn't. Please add an integration test for tslintAutoFix: true case and update README.md :) |
67bd084
to
b759110
Compare
@piotr-oles @johnnyreilly This is was a tricky change. Have taken an approach that shouldn't affect the other tests.
UPDATE: |
@ajainarayanan could you merge in the upstream changes please? |
1b5af9d
to
6da69a7
Compare
@johnnyreilly Have updated. |
…n autofix files in integration test
@piotr-oles @johnnyreilly Have updated the pull request. Can you give it another review. |
Just merged in upstream changes @ajainarayanan. @piotr-oles are you happy with the amends? |
@johnnyreilly @piotr-oles I know its a little ridiculous to request some changes in an open source library and expect a release to happen right away but I am blocked by this change (or a new version of fork-ts-checker) to integrate prettier into my project. Do we know tentatively when the pull request will be merged and a release will be cut? If any further changes are required please do let me know and I will make it. |
Hey @ajainarayanan , sorry this is a bit of a frustration for you. From my perspective I'm fine for this to be merged and shipped now. Given @piotr-oles requested changes (which you've generously done!) I'd like him to confirm he's happy with the work rather than me merge directly. If there's no response from him by the weekend then ping me again, maybe we can proceed without him. But that's not my preference. Apologies for the delay; I understand the frustration. |
Okay let's do this! Do you want to update the |
@johnnyreilly Thanks! Have updated both. Could you give it a review? |
Looks good - could you put the Default value of the field in the |
Thank you for your work and sorry for blocking this PR. Like @johnnyreilly said, please add default value to the README.md and then we're ready for release :) |
@piotr-oles @johnnyreilly Updated. Thanks for the review. |
Thanks! Should be available shortly |
tslintAutoFix
as a flag toForkTsCheckerWebpackPlugin
plugin in webpack config.IncrementalChecker
class update.Addresses #67