Working as expected on first line diagnostic.start #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/NormalizedMessage.ts
Outdated
| @@ -51,7 +51,7 @@ export class NormalizedMessage { | |||
| let character: number | undefined; | |||
| if (diagnostic.file) { | |||
| file = diagnostic.file.fileName; | |||
| if (!diagnostic.start) { | |||
| if (typeof diagnostic.start === 'undefined') { | |||
There was a problem hiding this comment.
Could this be diagnostic.start === undefined instead please? Marginally more performant and my personal preference.
|
Oh and yes updating |
package.json and CHANGELOG.md bump
|
@johnnyreilly looks like the tests were not passing in master as well due to |
|
Thanks! |
|
Should be released in 30 mins or so - thanks for the contribution! 🌻 |
SimonSchick
reviewed
Dec 14, 2018
| @@ -46,7 +48,7 @@ export class CancellationToken { | |||
| if (duration > 10) { | |||
| // check no more than once every 10ms | |||
| this.lastCancellationCheckTime = time; | |||
| this.isCancelled = fs.existsSync(this.getCancellationFilePath()); | |||
| this.isCancelled = FsHelper.existsSync(this.getCancellationFilePath()); | |||
There was a problem hiding this comment.
existsSync is NOT deprecated!
See https://nodejs.org/api/fs.html#fs_fs_existssync_path
There was a problem hiding this comment.
Oh that's correct! Would you care to submit a PR reverting that change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Typescript diagnostic starts on line 0, fork-ts-checker-webpack-plugin as of 0.5.1 fails and throws an error, which it shouldn't. This humble and small PR fixes it :) I'll update package.json and changelog.md if needed.