Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #424: Add onlyRequiredInSamples option #646

Merged
merged 3 commits into from
Oct 5, 2018

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Sep 16, 2018

Addresses #424

2018-09-16-93156

@exoego exoego changed the title Fix #424: Add skipNonRequired option Fix #424: Add onlyRequiredInSamples option Sep 16, 2018
@coveralls
Copy link

coveralls commented Sep 16, 2018

Coverage Status

Coverage increased (+0.03%) to 81.975% when pulling 57e0d10 on exoego:only-required-parameter into 56ad844 on Rebilly:master.

Copy link
Member

@RomanHotsiy RomanHotsiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one minor comment

Also would be great if you have some time to implement some basic test for this.
If you can't I'd be happy to merge this as is! 👍

@@ -39,12 +41,17 @@ export class MediaTypeModel {
}

generateExample(parser: OpenAPIParser, info: OpenAPIMediaType) {
const samplerOption = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename this to samplerOptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants