fix(graphHelpers,chartArea): issues/92 tooltip labels #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
changed the title
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Oct 16, 2019
…#113) * graphHelpers, fix the label display, added No Data * chartArea, fix tooltip positioning * locales, add in No Data
cdcabrera
commented
Oct 17, 2019
|
Correction for y axis ticks applied, should now appear as
|
Codecov Report
@@ Coverage Diff @@
## ci #113 +/- ##
==========================================
- Coverage 91.32% 91.28% -0.04%
==========================================
Files 27 27
Lines 553 562 +9
Branches 145 148 +3
==========================================
+ Hits 505 513 +8
- Misses 38 39 +1
Partials 10 10
Continue to review full report at Codecov.
|
…#113) * graphHelpers, fix the label display, added No Data * chartArea, fix tooltip positioning * locales, add in No data
* y axis ticks were being rounded incorrectly instead of abbreviated * updated package and unit test to confirm abbreviation continues
|
Updated tooltip, and expanded testing scenarios for when there isn't reporting data but there IS capacity/threshold
|
cdcabrera
added a commit
that referenced
this pull request
Oct 17, 2019
* graphHelpers, fix the label display, added No Data * chartArea, fix tooltip positioning * locales, add in No data
cdcabrera
added a commit
that referenced
this pull request
Oct 23, 2019
* graphHelpers, fix the label display, added No Data * chartArea, fix tooltip positioning * locales, add in No data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
How to test
Proxy run check
$ yarn$ yarn start:proxyExample
Updates issue/story
closes #92