Display Openshift route #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rhsmApiTypes, expanded rhsm response types * routerTypes, update product ids * rhelGraphCard, update default product id, rhsm types * rhelGraphCardHelpers, expanded rhsm types for tooltips * graphCardSelectors, expand towards additional rhsm types
cdcabrera
force-pushed
the
issues/157
branch
from
2a0cb22 to
6f771fb
Compare
* generate tooltips vs hard coded * expand switch granularity defaults * no data display
* convert towards generic select type * pass granularity select options type
* rhelView, pass props, graph card options, filter date * rhelGraphCard, props offset towards parent component
cdcabrera
force-pushed
the
issues/157
branch
from
6f771fb to
e70ca1b
Compare
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Dec 16, 2019
…hts#164) * routerTypes, apply openshift view, update route detail filter * router, expand passed values to getRouteDetail * rhelView, apply translation for titles * openshiftView, translation, mirror rhelView, filter core values * graphCard, prop for cardTitle * i18n, locale, heading, title strings
cdcabrera
force-pushed
the
issues/157
branch
from
e70ca1b to
e126585
Compare
Codecov Report
@@ Coverage Diff @@
## ci #164 +/- ##
=========================================
- Coverage 90.6% 90.45% -0.16%
=========================================
Files 28 29 +1
Lines 596 618 +22
Branches 156 156
=========================================
+ Hits 540 559 +19
- Misses 47 50 +3
Partials 9 9
Continue to review full report at Codecov.
|
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Dec 16, 2019
…hts#164) * routerTypes, apply openshift view, update route detail filter * router, expand passed values to getRouteDetail * rhelView, apply translation for titles * openshiftView, translation, mirror rhelView, filter core values * graphCard, prop for cardTitle * i18n, locale, heading, title strings
cdcabrera
force-pushed
the
issues/157
branch
from
8cf3f1a to
eebb9ad
Compare
…hts#164) * routerTypes, apply openshift view, update route detail filter * router, expand passed values to getRouteDetail * rhelView, apply translation for titles * openshiftView, translation, mirror rhelView, filter core values * graphCard, prop for cardTitle * i18n, locale, heading, title strings
cdcabrera
force-pushed
the
issues/157
branch
from
eebb9ad to
a2ceeef
Compare
cdcabrera
added a commit
that referenced
this pull request
Dec 19, 2019
* routerTypes, apply openshift view, update route detail filter * router, expand passed values to getRouteDetail * rhelView, apply translation for titles * openshiftView, translation, mirror rhelView, filter core values * graphCard, prop for cardTitle * i18n, locale, heading, title strings
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
Openshiftroute we'll need to temporarily enter it manually for testing. An update for the "source of truth" platform config is required to have it display in the left navigation.How to test
Proxy run check
$ yarn$ yarn start:proxy/beta/subscriptions/openshift-swand confirm that cores related content is being displayed, this includes:Example
Updates issue/story
Closes #157 #161