feat(graphCard,redux): issues/185 maintain state by view #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hts#202) * graphCard, required productId, initial granularity use options type * graphCardTypes, expand select default and options * graphReducer, apply viewId, avoid resetting state * graphCardSelectors, restructure, apply viewId * openshiftView, remove granularity, pathId, routeDetail required * rhelView, remove granularity, pathId, routeDetail required * rhsmActions, use generated metaId for state store * routerTypes, add pathId for state cache
cdcabrera
force-pushed
the
issues/185
branch
from
b1b3197 to
00b7639
Compare
Codecov Report
@@ Coverage Diff @@
## ci #202 +/- ##
==========================================
+ Coverage 90.64% 90.66% +0.02%
==========================================
Files 38 38
Lines 748 750 +2
Branches 185 187 +2
==========================================
+ Hits 678 680 +2
Misses 65 65
Partials 5 5
Continue to review full report at Codecov.
|
cdcabrera
added a commit
that referenced
this pull request
Feb 25, 2020
* graphCard, required productId, initial granularity use options type * graphCardTypes, expand select default and options * graphReducer, apply viewId, avoid resetting state * graphCardSelectors, restructure, apply viewId * openshiftView, remove granularity, pathId, routeDetail required * rhelView, remove granularity, pathId, routeDetail required * rhsmActions, use generated metaId for state store * routerTypes, add pathId for state cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
How to test
Proxy run check
$ yarn$ yarn start:proxyrhel/alland select a granularity type other thandailyExample
...
Updates issue/story
Updates #185