feat(openshiftView): issues/185 add cores sockets selector #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 13, 2020
…ights#205) * locales, add generic cardHeading string * graphCard, allow children to populate card actions * openshiftView, add cores sockets select list for graph filtering * rhelView, code style consistency against openshiftView
cdcabrera
force-pushed
the
issues/185-switcher
branch
from
1d98bfb to
41b92fe
Compare
…ights#205) * locales, add generic cardHeading string * graphCard, allow children to populate card actions * openshiftView, add cores sockets select list for graph filtering * rhelView, code style consistency against openshiftView
cdcabrera
force-pushed
the
issues/185-switcher
branch
from
41b92fe to
3a5c4b4
Compare
cdcabrera
changed the title
Codecov Report
@@ Coverage Diff @@
## ci #205 +/- ##
==========================================
+ Coverage 90.51% 90.69% +0.18%
==========================================
Files 38 38
Lines 759 774 +15
Branches 189 192 +3
==========================================
+ Hits 687 702 +15
Misses 67 67
Partials 5 5
Continue to review full report at Codecov.
|
|
LGTM! |
cdcabrera
added a commit
that referenced
this pull request
Feb 25, 2020
* locales, add generic cardHeading string * graphCard, allow children to populate card actions * openshiftView, add cores sockets select list for graph filtering * rhelView, code style consistency against openshiftView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
How to test
Proxy run check
$ yarn$ yarn start:proxyExample
Updates issue/story
Close #185