Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checkbox,formState): issues/240 form components #246

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

cdcabrera
Copy link
Member

What's included

  • feat(checkbox,formState): issues/240 form components
    • checkbox, pf wrapper component, emulated event obj
    • formState, maintain a forms state
    • select, group form components

Notes

  • Behind the scenes updates for form related components

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test

Example

...

Updates issue/story

#240

cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Apr 7, 2020
)

* checkbox, pf wrapper component, emulated event obj
* formState, maintain a forms state
* select, group form components
)

* checkbox, pf wrapper component, emulated event obj
* formState, maintain a forms state
* select, group form components
@codecov-io
Copy link

Codecov Report

Merging #246 into ci will decrease coverage by 0.61%.
The diff coverage is 87.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #246      +/-   ##
==========================================
- Coverage   92.97%   92.36%   -0.62%     
==========================================
  Files          42       44       +2     
  Lines         854      969     +115     
  Branches      210      232      +22     
==========================================
+ Hits          794      895     +101     
- Misses         56       69      +13     
- Partials        4        5       +1     
Impacted Files Coverage Δ
src/components/form/select.js 98.24% <ø> (ø)
src/components/graphCard/graphCard.js 73.07% <ø> (ø)
src/components/openshiftView/openshiftView.js 100.00% <ø> (ø)
src/components/toolbar/toolbar.js 95.45% <ø> (ø)
src/components/form/formState.js 86.79% <86.79%> (ø)
src/components/form/checkbox.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d289915...e709c79. Read the comment docs.

@cdcabrera cdcabrera merged commit d74efc8 into RedHatInsights:ci Apr 7, 2020
@cdcabrera cdcabrera mentioned this pull request Apr 10, 2020
cdcabrera added a commit that referenced this pull request Apr 10, 2020
* checkbox, pf wrapper component, emulated event obj
* formState, maintain a forms state
* select, group form components
@cdcabrera cdcabrera mentioned this pull request Apr 10, 2020
cdcabrera added a commit that referenced this pull request Apr 17, 2020
* checkbox, pf wrapper component, emulated event obj
* formState, maintain a forms state
* select, group form components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants